search

cabal-club / cabal-desktop

Desktop client for Cabal, the p2p/decentralized/local-first chat platform.
https://cabal.chat
GNU Affero General Public License v3.0
850 stars 78 forks source link

Archive channels #305

Closed nikolaiwarner closed 3 years ago

nikolaiwarner commented 3 years ago
Screen Shot 2021-03-16 at 8 50 35 AM Screen Shot 2021-03-16 at 8 54 32 AM

This also bumps Cabal Desktop to use the latest cabal-client and does just a little code cleanup.

cblgh commented 3 years ago

@nikolaiwarner nice! 🍰 i think there is more margin than needed between the leave channel / archive channel buttons in the first screenshot, do you agree with making it a bit tighter?

nikolaiwarner commented 3 years ago

@nikolaiwarner nice! 🍰 i think there is more margin than needed between the leave channel / archive channel buttons in the first screenshot, do you agree with making it a bit tighter?

thanks! yeah, i also think i should swap leave and archive. since one may leave more often than archive.

i'm in a weird place with this codebase really. i'm quite ready to start from scratch... approaching this project with what we've learned over three years, meets our current goals, and does things in the most modern and efficient way. that of course would be the project that builds the desktop client and the interface for browsers. so i guess what im saying is that this might be the last feature until cabal-desktop-next

cblgh commented 3 years ago

i'm in a weird place with this codebase really. i'm quite ready to start from scratch... approaching this project with what we've learned over three years, meets our current goals, and does things in the most modern and efficient way.

i hear ya :)

that of course would be the project that builds the desktop client and the interface for browsers. so i guess what im saying is that this might be the last feature until cabal-desktop-next

💯 i think it's at the perfect stopping off point for new features as well, considering the timing of starting on cabal-web. i think the exception would be tiny bug fixes for people using the clients in the interim? i'm mainly thinking of finding a fix for messages showing up twice. that's easy for me to say tho, considering i mostly pull my weight in the other repos 😅

anyway, nice!!! it would be cool if we could add the context you wrote in the comments above inside the source as code comments, other than that 🚢 📦 it! 🖤

nikolaiwarner commented 3 years ago

I'll clean things up with your suggestions then make a build that i'll share privately with some folx. I'd like to test things out real good before merging this and releasing.

cblgh commented 3 years ago

I'll clean things up with your suggestions then make a build that i'll share privately with some folx. I'd like to test things out real good before merging this and releasing.

heck yeah! i'll give it a spin on my win desktop some time this week then :)