Remove scroll bug - Githubissues

cabal-club / cabal-desktop

Desktop client for Cabal, the p2p/decentralized/local-first chat platform.

https://cabal.chat

GNU Affero General Public License v3.0

843 stars 77 forks source link

Remove scroll bug #307

Closed Gronis closed 3 years ago

Gronis commented 3 years ago

Don't call scrollIntoView on every message.
Handle scroll logic in mainPanel only.
Scroll to bottom when sending a message.

Gronis commented 3 years ago

Fixes #308

Gronis commented 3 years ago

I noticed another bug related to scrolling after pushing my first commit.

After opening and closing "cabal settings" panel, the scroll listener is not working, because it was mounted to an old html element not in the DOM anymore. I tried to make mainPanel a pure component and using some hooks, but I didn't get the correct behavior, so I decided to scrap that and just made a smaller change which make sure that the scroll listeners are correct.

cblgh commented 3 years ago

cc @khubo @nikolaiwarner wdyt?

nikolaiwarner commented 3 years ago

Looks good! Fantastic work @Gronis !! 🔥🔥🔥🔥