search

cabaletta / baritone

google maps for block game
GNU Lesser General Public License v3.0
7.23k stars 1.45k forks source link

Command to change the range of Baritone #1081

Closed j13li78 closed 5 years ago

j13li78 commented 5 years ago

Describe your suggestion

Right now Baratione uses a increased range wich doesn't work on all servers. Example: https://gyazo.com/14b883afd6ad5d75fd318d8bcc3657d0

Settings

A float to change the range like ".b range 3.0".

Context

It would make it work on some server that doesn't allow increased range

Final checklist

0-x-2-2 commented 5 years ago

baritone uses the vanilla block reach.

j13li78 commented 5 years ago

baritone uses the vanilla block reach.

even tho you can see it's too high on some servers so a setting to change it would be nice

ThebesAndSound commented 5 years ago

2b2t is no longer the vanilla block reach, its slightly less meaning baritone keeps getting stuck especially when using cleararea. I am asking hause to fix it so this setting shouldn't be necessary at least for 2b.

0-x-2-2 commented 5 years ago

I don't think this is even in the scope of baritone anyways.

leijurv commented 5 years ago

Baritone overrides vanilla's block reach distance so it should at least be a setting, otherwise there would be literally no workaround possible

0-x-2-2 commented 5 years ago

Baritone overrides vanilla's block reach distance so it should at least be a setting, otherwise there would be literally no workaround possible

Wtf?

0-x-2-2 commented 5 years ago

https://github.com/cabaletta/baritone/blob/518fa1c74daa7e8b9f764038410cc7b4fb982e94/src/main/java/baritone/utils/player/PrimaryPlayerContext.java#L61

This Looks fine?

0-x-2-2 commented 5 years ago

Nice trolle. This is fake news.

https://github.com/cabaletta/baritone/blob/5c83ee264820cacd9ae133918faf3afd8541095b/src/api/java/baritone/api/utils/RayTraceUtils.java#L42

This is almost IDENTICAL to what the game does except it uses interpolated eye position and direction and I doubt that is the issue.

leijurv commented 5 years ago

look harder lmao https://github.com/cabaletta/baritone/blob/518fa1c74daa7e8b9f764038410cc7b4fb982e94/src/api/java/baritone/api/utils/IPlayerController.java#L49

0-x-2-2 commented 5 years ago

look harder lmao https://github.com/cabaletta/baritone/blob/518fa1c74daa7e8b9f764038410cc7b4fb982e94/src/api/java/baritone/api/utils/IPlayerController.java#L49

these are vanilla the constants and this code is the same as vanilla.... nice "look harder"...

leijurv commented 5 years ago

I stand by what I said

Baritone overrides vanilla's block reach distance so it should at least be a setting, otherwise there would be literally no workaround possible

This is true. Since 2b2t has a lower block reach distance than vanilla, we should have some way to change this because it's hardcoded in our code, while some other mod could conceivably change vanilla's max to match.

ghost commented 5 years ago

I'd love that.

0-x-2-2 commented 5 years ago

2ae16d8bb1cd6bed87fe2a4858ac2e5458911079