Add "Ignore Not Exposed Ores" Option in AutoMine

fee1-dead commented 4 years ago

Describe your suggestion

This option should ignore ores that are not exposed to the air, because some servers use anti-Xray and they will replace not exposed stone with fake ores.

Settings

There should be an option in automine that will automatically filter out not exposed ores.

Context

For servers that use anti-Xray plugins, this would be very helpful to automine, because then we can only use legit mine, but we can also use Xray but only targeting exposed ores.

koraseeq commented 4 years ago

#legitMine does that I think

fee1-dead commented 4 years ago

#legitMine does that I think

LegitMine will only mine ores that baritone can see, I want a feature that use xray to find ores, but also ignoring buried ores.

Mentalgen commented 4 years ago

Wouldn’t you need world data before coming to a chunk to see which ores are real? Most Anti-Xray plugins change the blocks physically and not just visually so it fucks everything up. I would expect only the server knows which ones are the real ores...which is where legitmine comes in since it wont go after any ores that are inside walls.

SeasonalFerret commented 4 years ago

Most anti-xray plugins will only obfuscate blocks that can not be seen normally. So if you're xraying and you see a vein in the open in a ravine, 99% of the cases that's a real ore. Pretty sure they do this so that it doesn't cause ores to just "pop in" infront of users who may lag slightly.

With that being said, baritone technically doesn't have any form of anti-xray mining. Legitmine definitely works 100% for this case, but it also requires the bot to randomly stumble upon the ore and won't mine directly to ores that are in contact with (cave_)air. If you just want to get diamonds as fast as possible in a server with ore obfuscation, baritone should have a setting for ore obfuscators where it only targets blocks in contact with air.

pozhiloy-enotik commented 4 years ago

30.08.2020 still the same problem

ghost commented 4 years ago

added this option pls :D

SeasonalFerret commented 4 years ago

guys calm down I'm waiting for a very important email and you fuckers keep ringing my phone making me jump out of my chair

I swear some people really dont look through the settings

Toggle legitMine on and set the legitMineYlevel to whatever level the ore is usually spawning at

I swear some people really don't look through the comments

LegitMine will only mine ores that baritone can see, I want a feature that use xray to find ores, but also ignoring buried ores.

pozhiloy-enotik commented 4 years ago

#legitMine does that I think

LegitMine will only mine ores that baritone can see, I want a feature that use xray to find ores, but also ignoring buried ores.

@SylveonBottle @RealIndrit

SeasonalFerret commented 4 years ago

basically we WANT an xraying bot, we don't want to look legit. We just don't want the bot to go to ores spoofed by ore obfuscators

@RealIndrit Imagine turning on legit mine with engine mode 2 and watching baritone fucking kill itself

Ore obuscators can't spoof ores near air blocks (or most don't since it's insanely computationally challenging to check the POV of every player just to hide fucking iron), so having a mode that can ignore BURIED ores and only go for ores near air blocks is what this suggestion is about.

pozhiloy-enotik commented 4 years ago

@SylveonBottle That's the point. Maybe, we should make a vote to reopen this?

SeasonalFerret commented 4 years ago

@SylveonBottle That's the point. Maybe, we should make a vote to reopen this?

I've demanded that we had this issue re-open since some idiot closed it because they couldn't be assed to listen to what OP and others was trying to describe

SeasonalFerret commented 4 years ago

fucking 2015 huzuni had an xray option to "hide buried ores" to bypass anti-xray's like ore obfuscator. Why doesn't baritone have this yet?

Mentalgen commented 4 years ago

yeah, no idea why it was closed either, no reason given :/ Been a while since I use Baritone but the #legitMine only goes in a single line till it runs into ores right? The whole point of the suggestion was that you could see the ores but the bot wasn't even trying to mine them. Make it so that if it sees that you're in a cave/ravine, to check for ores there.

Also please explain more about the whole "hiding" ores, as in you have to walk next to the block to see the ore?

5HT2 commented 4 years ago

legit mine will go and mine exposed ores. I closed this because #legitMine already exists and the original issue wasn't as clear.

fee1-dead commented 4 years ago

true

fee1-dead commented 4 years ago

Anti-Xray plugins creates fake ores but we know that exposed ores (that touch air, (flowing) water, lava) are real and with this option it can xray hidden ores e.g. in caves, lava pools, some servers checks transparent blocks in two block radius to be more lag-friendly, so it can be a number option (0 being off, others define radius)

SeasonalFerret commented 4 years ago

They also won't hide ores that are 1 block away from air as well (hidden behind a block). Because if someone breaks the block, lag will result in them seeing fake gold/diamond etc.

So really this can be applied to "if it's within 2 blocks of an air block".

Generally most anti-xray servers will have the fake ores disappear within a certain radius, so it can also be applied to "within X blocks of user are also real".

x4e commented 4 years ago

Can’t reproduce, please mark this as invalid

OccasionalBree commented 4 years ago

Can’t reproduce, please mark this as invalid @cookiedragon234

What?

OccasionalBree commented 4 years ago

+1, this would be a great thing

I want a feature that use xray to find ores, but also ignoring buried ores.

x4e commented 4 years ago

Can’t reproduce, please mark this as invalid

@cookiedragon234

What?

What?

SeasonalFerret commented 4 years ago

Can’t reproduce, please mark this as invalid

Ah yes, the "since I'm not having this issue, it means the issue doesn't exist" idiot. AND the "I have no fucking clue where I am" commenter.

Wrong issue, buddy. In fact wrong github project entirely. In fact, wrong website. You're looking for https://www.cartoonnetwork.com/

5HT2 commented 4 years ago

Can you all cool it? I've seen nothing but hostility in this issue. I'm tempted to just ask leij to lock it because this is nuts

OccasionalBree commented 4 years ago

I'm tempted to just ask leij to lock it because this is nuts

Issues won't be solved if you lock them

SeasonalFerret commented 4 years ago

Can you all cool it? I've seen nothing but hostility in this issue. I'm tempted to just ask leij to lock it because this is nuts

Imagine not adding killaura because people were being mean in the comments section 😭

5HT2 commented 4 years ago

what??

Mentalgen commented 4 years ago

what the fuck happened here. This was just a suggestion ;w;

pozhiloy-enotik commented 4 years ago

Hello. Any progress on this?)

fee1-dead commented 4 years ago

This issue should be closed because I don't use baritone and I don't play minecraft anymore.

SeasonalFerret commented 4 years ago

This issue should be closed because I don't use baritone and I don't play minecraft anymore.

If you close it because of that stupid reason, I'm going to create a new issue copy/pasted because I still use baritone and I still play minecraft.

x4e commented 3 years ago

Can’t reproduce, please mark this as invalid

Ah yes, the "since I'm not having this issue, it means the issue doesn't exist" idiot. AND the "I have no fucking clue where I am" commenter.

Wrong issue, buddy. In fact wrong github project entirely. In fact, wrong website. You're looking for cartoonnetwork.com

@SylveonBottle Please review the Github Community Guidlines and Baritone Code Of Conduct, then rephrase your comment using the language of someone over the age of 8.

SeasonalFerret commented 3 years ago

Can’t reproduce, please mark this as invalid

Ah yes, the "since I'm not having this issue, it means the issue doesn't exist" idiot. AND the "I have no fucking clue where I am" commenter. Wrong issue, buddy. In fact wrong github project entirely. In fact, wrong website. You're looking for cartoonnetwork.com

@SylveonBottle Please review the Github Community Guidlines and Baritone Code Of Conduct, then rephrase your comment using the language of someone over the age of 8.

Ok boomer

x4e commented 3 years ago

Can’t reproduce, please mark this as invalid

Ah yes, the "since I'm not having this issue, it means the issue doesn't exist" idiot. AND the "I have no fucking clue where I am" commenter. Wrong issue, buddy. In fact wrong github project entirely. In fact, wrong website. You're looking for cartoonnetwork.com

@SylveonBottle Please review the Github Community Guidlines and Baritone Code Of Conduct, then rephrase your comment using the language of someone over the age of 8.

Ok boomer

Not sure if you find this funny or something but I do not

OccasionalBree commented 3 years ago

Not sure if you find this funny or something but I do not

What do you want now?

5HT2 commented 3 years ago

Petition to lock

Mentalgen commented 3 years ago

It appears that someone has gone and implemented this function. As such I'm satisfied, and we should all now calm down and act like civil fuckin humans. Voting to lock

LHill-16 commented 3 years ago

What on earth happened here oh god

SeasonalFerret commented 3 years ago

What on earth happened here oh god

Somebody made a suggestion that's really good and honestly I wish I could've made it myself. Then somebody who didn't even read the suggestion closed the issue, stating "op didn't make himself clear enough", so I had to make it clear for him. Then some dude got lost and thought he was replying to an issue report, I told him off, he cried, I made a joke, he cried some more.

Basically, just people trying to close this for the dumbest reasons until it was finally implemented.

x4e commented 3 years ago

If you do not treat this discussion with respect I will be forced to ban you from the baritone repository.

SeasonalFerret commented 3 years ago

If you do not treat this discussion with respect I will be forced to ban you from the baritone repository.

The issue's over, it got closed a while ago. What respect are you asking for? "Hey, thank you for closing this issue was being invalid, I'm sorry for thinking that you got lost since another staff member handled it way better than you"?

scorbett123 commented 3 years ago

This issue is closed and has been implemented, please stop arguing in this issue. It just notifies a bunch of people for no real reason.

If you do not treat this discussion with respect I will be forced to ban you from the baritone repository.

I don't believe that you can do this either.

leijurv commented 3 years ago

Lol I have no idea who x4e is but they definitely can't ban anyone from this repository.

x4e commented 3 years ago

I have no idea who Leijurv is but they definitely can't tell me whether or not I can ban someone from this repository.

SeasonalFerret commented 3 years ago

So my original assumption is correct then? That x4e doesn't know where he is I mean. I guess he really is the troll here.. huh. Actually baited me with those troll responses, congrats

FYI if anyone subscribed to this thread doesn't want to get emails for every response you can, ya'know, unsubscribe from it.

leijurv commented 3 years ago

lmao owned

Drakesdrs commented 3 years ago

bruh what is this

cabaletta / baritone