search

cabaletta / baritone

google maps for block game
GNU Lesser General Public License v3.0
7.25k stars 1.45k forks source link

acceptableThrowawayItems is being moved into players hotbar, when baritone is inactive #3409

Open Rumrobot opened 2 years ago

Rumrobot commented 2 years ago

Describe your suggestion

Add a setting, or remove the thing where baritone constantly moves acceptableThrowawayItems into the player's hotbar. Or at least make it so it doesn't do it while baritone is inactive. Then there is no need for it.

Settings

There could be a setting for it, but it isn't necessary. Something like acceptableThrowawayItemsPriority = true/false could maybe work.

Context

It's annoying when playing Minecraft, and the acceptableThrowawayItems is being moved into the player's hotbar. It's interrupting a lot when playing.

ZacSharp commented 2 years ago

This is a feature you explicitly enabled by setting allowInventory to true, why are you reporting it as a bug? If you think the intended behaviour should be changed you should open a "suggestion issue instead of reporting the current behaviour as a bug.

I'll just change the label and it would be nice if you could edit your issue to contain a little more information (look at the suggestion template for what to put in it).

Rumrobot commented 2 years ago

Thx i will do that, but i would call it a bug since baritone is inactive. Is it made to specifically do it like that? And then what would the point be to have it do it, while it has nothing to do?

ZacSharp commented 2 years ago

I think that's intended. It's doing it here https://github.com/cabaletta/baritone/blob/cbef05838db84ec77f7a14234b44675a1bc9e5ab/src/main/java/baritone/behavior/InventoryBehavior.java#L57 since the inventory handling was added 3 years ago and I never saw a sign of someone considering it wrong behavior. There is checks to disable it in containers or while not ingame (and of course when allowInventory is disabled) but nothing to check whether we actually need the items.

liangforstudy commented 2 years ago

Oh yeah, I find this annoying as well. Sometimes there's a cobblestone/dirt block on my 9th slot on my hotbar. And when I tried to keep that in my inventory, Baritone keep placing it back into my 9th slot on my hotbar until I turn @ allowinventory off. But I also needed baritone to access my inventory for convenience.