cabaletta / baritone

google maps for block game
GNU Lesser General Public License v3.0
7.27k stars 1.45k forks source link

Add support for additional schematic formats #387

Open rebane2001 opened 5 years ago

rebane2001 commented 5 years ago

Right now, the schematic builder only has support for the .schematic file format, which is outdated
It'd be really useful to also have support for the modern .nbt file format

ZeroMemes commented 5 years ago

The schematic file format standard has always been NBT. Do you mean Sponge's Schematic Specification which was designed to support the removal of integer block ids?

https://github.com/cabaletta/baritone/blob/866408aece4d663061bfcc00ba2b6547cc4042ec/src/main/java/baritone/utils/schematic/Schematic.java#L31-L68

0-x-2-2 commented 5 years ago

smile

rebane2001 commented 5 years ago

@ZeroMemes

I'm talking about the native .nbt file format (not to be confused with the NBT file structure) that does indeed not use block IDs It's the same format that Minecraft's structure blocks use. It's also supported by many programs, like MCEdit Unified and Schematica

0-x-2-2 commented 5 years ago

@rebane2001 schematic files are just nbt so what do you mean 🤔

rebane2001 commented 5 years ago

@0-x-2-2 I specifically mentioned "not to be confused with the NBT file structure" in my previous reply. I'm talking about .nbt files. What you're talking about are .schematic files that use the NBT file structure.

0-x-2-2 commented 5 years ago

Minecraft stores all random nbt data as .nbt

0-x-2-2 commented 5 years ago

Anyways I know that you are talking about what the structure blocks uses. Schematica implementation is here. The sponge format is probably way better then this.

rebane2001 commented 5 years ago

It doesn't matter which format is better. The reason I want the modern structure file format is because it is common and used by many programs now, which means many can't use the files they wish to use with Baritone

ZeroMemes commented 5 years ago

The sponge format is probably way better then this.

The idea is for a wide range of compatibility. d🤡b

0-x-2-2 commented 5 years ago

structure block format modern literally just a tile entity stored in nbt

????????????????????????????????????????????????????

Bendito999 commented 5 years ago

Here's where rebane's coming from he wants it to work with the .nbt that https://rebane2001.com/mapartcraft/
makes. This would be coolio because then we won't have to import via mcedit then save/export the selection as .schematic just to make his turnkey mapart schematic generator work. +1 for more formats