search

cabaletta / baritone

google maps for block game
GNU Lesser General Public License v3.0
7.12k stars 1.42k forks source link

If have silk touch pick, then use it on glowstone #783

Open RainOfPain125 opened 5 years ago

RainOfPain125 commented 5 years ago

Describe your suggestion

I set Baritone to auto-mine glowstone, and it chose to break it with fish/fists instead. Breaking with a silk touch pickaxe would be much more preferable in 90% of situations

Settings

Allow/Disallow silk priority

Context

Self explanitory

Final checklist

LoganDark commented 5 years ago

Even with a silk-touch pickaxe in my hotbar (and nothing else), it still chooses to switch away from it to mine the glowstone.

bddvlpr commented 5 years ago

Because it prefers the fastest way of breaking it.

RainOfPain125 commented 5 years ago

Because it prefers the fastest way of breaking it.

Is breaking with hands faster than pickaxe?

Even if so, if we're explicitly telling Baritone to mine for glowstone (or for that matter, anything that can be silk touched) it should have an option to prefer compatible silk touch tools.

LoganDark commented 5 years ago

or for that matter, anything that can be silk touched

Most things can be silk touched, including ores, grass and so on. What's should the criteria be for Baritone using a silk touch pick? Should there also be an option for Baritone to use a fortune pick when mining ores, but still use silk touch for glowstone and such?

RainOfPain125 commented 5 years ago

Should there also be an option for Baritone to use a fortune pick when mining ores, but still use silk touch for glowstone and such?

This HIGHLY depends on the situation. If a server has McMMO it is 100% more preferably to use silk touch on all ores, because it has a chance of giving you double the ore, which you would later use a fortune pick on.

LoganDark commented 5 years ago

This HIGHLY depends on the situation. If a server has McMMO it is 100% more preferably to use silk touch on all ores

did you miss the word 'option'

Jeffmagma commented 4 years ago

I just ran into this issue too, and the reason you would mine glowstone with silk touch is because it yields the best drops (fortune 3 gives 2-4 glowstone dust, 4 glowstone dust makes one glowstone) so mining it with your bare hands isn't faster AND it yields worse drops. I just feel like if the only tool I am holding is a silk touch pickaxe, it should be recognized as better than just bare hands.

5HT2 commented 2 years ago

This is still a problem lol. I don't think that hardcoding an exception for this (or a setting) is a bad idea.

scorbett123 commented 2 years ago

Yea, possibly hardcoding, however a better solution would be preferable. A while ago me and @ZacSharp were talking about improving the auto-tool so that this could be done, however we haven't really got anywhere with that.

Also you know the baritone repo, most issues are pretty unlikely to ever be fixed.

5HT2 commented 2 years ago

most issues are pretty unlikely to ever be fixed.

I'll just close them as invalid /j

ZacSharp commented 2 years ago

I actually have some crappy prototype crammed into a single class, allowing you to set up rules for autotool (with clickable chat text and all) and to ask it which tool it would choose and nothing more. No permanent saving of rules, no integration in the actual autotool, no proper api, I'm not even sure whether I got the tool "selection" to work. The main problems with getting it into a useable state were knowing what I want, specifically how the rating algorithm is supposed to work (ideas welcome). The algorithm I implemented is basic n-tuple sorting, so no complex things like "the cheapest tool but only if it's at most 50% slower than the fastest". Now while writing this I'm also thinking about whether something like css selectors would be a good idea ("fastest for all cases, silktouch for ores with double importance, fortune for just this single ore with triple importance").