search

cabalex / fnf-song-converter

9 stars 11 forks source link

Lost Notes #15

Closed your-acc closed 2 years ago

your-acc commented 2 years ago

When I used the chart converter, the beginning part where the player doesn't repeat the notes gets lost and is (almost) identical to the original, even in the pixel part where it's all default! Don't believe me? type "73" in song selector here: https://scratch.mit.edu/projects/631532535/

your-acc commented 2 years ago

Video form if you don't want to/can't view it; https://user-images.githubusercontent.com/82058673/157147028-f14efc7c-c64e-45cf-a910-b56bf65ea43e.mp4

cabalex commented 2 years ago

Do you have the original chart JSON file you used to convert? I'd love to take a look and see what's going on.

your-acc commented 2 years ago

You can tell I get everything wrong by two deleted messages. New Text Document.txt also yeah this is the .json dumped into a .txt (because github can't read .json)

cabalex commented 2 years ago

Found the issue! This song uses an abnormal amount of data for the notes (5 total data fields per note compared to the 3 in vanilla). Changing extended note handling to "allow all notes (experimental)" would have fixed the issue.

However, this adds some extra data that the Scratch base engine doesn't know how to handle [note length breaks], so I've added some extra truncating options to the converter. See the wiki for more information, but for your use case you would set it to Allow all notes, truncate extra data (EXPERIMENTAL).