search

cabalism / hpack-dhall

Use hpack's phrasing in dhall to write cabal files
BSD 3-Clause "New" or "Revised" License
31 stars 3 forks source link

Generated description has extra newlines in YAML. #25

Closed philderbeast closed 3 years ago

philderbeast commented 5 years ago

For the stack golden test, the description generated has extra newlines compared to the expected output;

Expected stack.yaml.golden file;

description: ! 'Please see the README.md for usage information, and
  the wiki on Github for more details.  Also, note that
  the API for the library is not currently stable, and may
  change significantly, even between minor releases. It is
  currently only intended for use by the executable.'

Generated stack.yaml file;

description: ! 'Please see the README.md for usage information, and

  the wiki on Github for more details.  Also, note that

  the API for the library is not currently stable, and may

  change significantly, even between minor releases. It is

  currently only intended for use by the executable.'
DanBurton commented 5 years ago

Bump. Just wanted to note that this test failure was observed on the Stackage build server.

I was able to reproduce this locally like so:

stack unpack hpack-dhall-0.5.1 && cd hpack-dhall-0.5.1
echo 'resolver: nightly-2019-02-17' > stack.yaml
stack build --test --bench --no-run-benchmarks --fast
DanBurton commented 5 years ago 
    .dhall to yaml
      hpack:             OK
      stack:             WARNING: Specified file "CHANGELOG.md" for extra-source-files does not exist
WARNING: Specified source-dir "driver" does not exist
WARNING: Specified source-dir "src" does not exist
WARNING: Specified source-dir "test" does not exist
FAIL (0.01s)
        Files 'test/golden/test-files/real-world/stack/stack.yaml.golden' and 'test/golden/test-files/real-world/stack/stack.yaml' differ
philderbeast commented 3 years ago

We now require base >= 4.13, implying GHC >= 8.8.4, as of hpack-dhall-0.5.3.