cabalism / hpack-dhall

Use hpack's phrasing in dhall to write cabal files
BSD 3-Clause "New" or "Revised" License
31 stars 3 forks source link

With stackage nightly ghc-8.6.2 test ".dhall to dhall/stack" failed. #26

Closed philderbeast closed 5 years ago

philderbeast commented 5 years ago

When checking before adding hpack-dhall to stackage nightly, I found it failed one of the golden tests when following the procedure for adding a package:

# Build from the tarball on Hackage to check for missing files
$ stack unpack yourpackage && cd yourpackage-*
# Generate a pristine stack.yaml, adding any missing extra-deps
$ rm -f stack.yaml && stack init --resolver nightly --solver
# Build, generate docs, test, and build benchmarks
$ stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

Generating stack.yaml with stack init was failing with:

$ rm -f stack.yaml && stack init --resolver nightly --solver
Looking for .cabal or package.yaml files to use to init the project.
Using cabal packages:
- ./
- test/golden/test-files/key/
- test/golden/test-files/key/empty-inferred/
- test/golden/test-files/key/import-local/
- test/golden/test-files/key/import-relative/
- test/golden/test-files/real-world/hpack/
- test/golden/test-files/real-world/stack/

Multiple .cabal files found in directory /.../hpack-dhall-0.5.0/test/golden/test-files/key/
: empty-package.cabal
, when-dependencies.yaml.cabal
, empty-package.yaml.cabal
, when-dependencies.cabal

I added --ignore-subdirs to filter out the *.cabal files of the golden tests.

-- $ rm -f stack.yaml && stack init --resolver nightly --solver
++ $ rm -f stack.yaml && stack init --resolver nightly --solver  --ignore-subdirs
> ls -R **/*.cabal
test/golden/test-files/key/empty-inferred/empty-inferred.cabal
test/golden/test-files/key/empty-inferred/package.yaml.cabal
test/golden/test-files/key/empty-package.cabal
test/golden/test-files/key/empty-package.yaml.cabal
test/golden/test-files/key/import-local/import-local.cabal
test/golden/test-files/key/import-local/package.yaml.cabal
test/golden/test-files/key/import-relative/import-relative.cabal
test/golden/test-files/key/import-relative/package.yaml.cabal
test/golden/test-files/key/when-dependencies.cabal
test/golden/test-files/key/when-dependencies.yaml.cabal
test/golden/test-files/real-world/hpack/hpack.cabal
test/golden/test-files/real-world/hpack/hpack.yaml.cabal
test/golden/test-files/real-world/stack/stack.cabal
test/golden/test-files/real-world/stack/stack.yaml.cabal

The test that failed is .dhall to dhall/stack:

    .dhall to dhall
      hpack:             OK
      stack:             FAIL (0.01s)

The stack.yaml initialised from hpack-dhall.cabal is:

resolver: nightly-2018-11-27
packages:
- .
philderbeast commented 5 years ago

Another test has also failed:

.dhall to dhall
      import-local:      OK
      when-dependencies: FAIL