cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.
MIT License
165 stars 107 forks source link

Feat Multiplier bug in version 1.5.5a #1026

Open gkan144 opened 1 year ago

gkan144 commented 1 year ago

Description of the bug

The bug described here: https://github.com/cabarius/ToyBox/issues/354 still exists:

Steps To Reproduce

  1. Select a Feature Selection multiplier higher than 1
  2. Activate Apply Feature Selection Multipler to party members
  3. Level up a character
  4. Feats and abilities that were not selected are added in the final screen. These extra feats are not actually added to the character. But they block selecting that feat in the regular level up screen.

Expected Behavior

The Feature Selection multiplier is applied correctly to the rest of the party members.

Log Files

No response

Save File

No response

Screenshots

image

Settings

No response

Toybox Version

1.5.5a

Operating System

Windows

What game are you using Toybox on?

Pathfinder Wrath of the Righteous

Game Version

2.1.4w

Anything else?

No response

luqman0102 commented 1 year ago

i reported on this bug updates ago. seems there hasn't been a solution yet

CasDragon commented 12 months ago

Can not replicate your issue (and likely couldn't when you first posted this). Started a new save, walked up to Seelah, gave her a level, turned the feat multiplier to 3, and gave her a level in Fighter, and got the expected extra feats.

Please update your Toybox to the latest version (1.5.7), and try again. If the issue persists, we'll likely need your log files.

ShadowShamanh commented 11 months ago

The bug still exists in the latest version.

CasDragon commented 11 months ago

Provide logs and a save file (preferably with no other mods, otherwise provide the modlist as well). As stated, I can not replicate your issue (or the original poster's) with the current version (which I literally stated in the previous comment)

ShadowShamanh commented 11 months ago

What logs do you need? Saves.zip

ShadowShamanh commented 11 months ago

Nvm

Player.log

GameLogFull.txt

CasDragon commented 11 months ago

As before, I'm unable to replicate your issue, with either of the saves you provided. I'm not seeing any specific errors that would be causing the feature to not work.

So a couple steps you can try is to verify your game files, reinstall UMM, and download the latest version of Toybox again.

ShadowShamanh commented 11 months ago

Sadly the bug still persists.

gkan144 commented 11 months ago

@CasDragon I no longer have the game installed so I cannot help. Do you know of some way to active more verbose logs in the game? It might help you find out what is going on.

@ShadowShamanh I would suggest you go through a levelup during a play session so that the logs include any relevant entries. For example, start a new game, put the multiplier to maximum, and level up one or two of the companions. I am sure I have seen this issue with Camelia and Seelah. It might also be helpful to have a before and after save, keep track of the feats the companion had before the level up and after, and also keep track of which feats you were allowed to select during level up.

I have replication steps for this issue in my comment in the original issue (here). They might help.

ShadowShamanh commented 11 months ago

Longer session till lann. x5 multiplier Companions trying to add feats that are in auto leveling option.

Saves.zip

Player.log

GameLogFull.txt

kpgrimes commented 2 months ago

The closed report references picking "random" feats, but what it looks like it's doing is adding character backgrounds. For example one of the feats added in the screenshots in the old report is the Smith background, which comes with Warhammer proficiency. I assume there's no update on this?

CasDragon commented 2 months ago

There's no update because we haven't been able to replicate it, and the provided logs/save files don't contain any errors causing it. This report hasn't been closed though, unsure why you think that.

If you are experiencing this issue yourself, please provide logs and a manual save file, and we can take another look.

kpgrimes commented 2 months ago

Saves.zip GameLogFull.txt

The log file is a lot of gibberish to me, but out of curiosity I searched for "Background" and there are a bunch of references to backgrounds and Camelia. She's the one I levelled up.

CasDragon commented 2 months ago

Those errors aren't explicitly Toybox errors, but those are weird errors. Do you have the "auto companion level up" option thingy on, by chance? Also, could you please provide the Player.log as well?

If it's not figured out by morning, I'll load your saves then to see if I can replicate it (as I'm about to go off to bed)

kpgrimes commented 2 months ago

Player.log

I've got auto level and retrain turned off in the difficulty settings.

Thanks for taking a look!

CasDragon commented 2 months ago

Don't see anything in that log either.

That being said... [0ToyBox0] Version '1.5.13'. Loading.

Update your Toybox, you are pretty far out of date. Narria hasn't been around to update the Nexus page, so here's the link to it. https://github.com/xADDBx/ToyBox-Wrath/releases/tag/v1.5.24

I don't think this will solve the problem, because I don't believe ADDB has changed anything with that specific code, but you never know.

If it continues to happen with the new version, GameLogFull.txt and Player.Log one more time. Hopefully this time we'll see the actual error (This is the worst type of bug, one where we can't replicate nor are there any real errors. It's very frustrating)

gkan144 commented 2 months ago

This is still happening in the latest version. I will try to get logs/saves later on in the day

kpgrimes commented 2 months ago

GameLogFull.txt Player.log Saves 2.zip

Here you go. The new version of ToyBox required a new version of UMM as well, so I updated that. Also disabled all other mods. Camelia was still the one I levelled up.

kpgrimes commented 2 months ago

This section from GameLogFull.txt here is sort of what I was talking about. It looks like it's trying to go back and fill in old level 1 background selections.

[67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection HalfElfHeritageSelection [67.3234 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3234 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3234 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3234 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3234 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3234 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3244 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3244 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3244 - Default]: Trying to select default value for selection BackgroundsBaseSelection [67.3244 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3244 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3244 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3244 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3244 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3244 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3244 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3254 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3254 - Default]: Trying to select default value for selection ShamanSPiritSelection [67.3254 - Default]: Can't find suitable item for selection ShamanSPiritSelection

CasDragon commented 2 months ago

Hate to say it again, but I'm still unable to replicate it on my end. That being said, I don't have any errors in my GameLogFull about trying to select backgrounds either. Perhaps you have a corrupted game file maybe? You could try verifying your game files in Steam, and see if it replaces/downloads any new files.

Otherwise, I guess I'll just tag @xADDBx and see if he sees anything I missed.

gkan144 commented 2 months ago

Ok so:

I saw this today again with Ulbrig:

He is level 4 and does not have the Toughness feat before

I try to add it in when I level up but it is already considered acquired during 1

At the end of the level up screen I can see that Toughness is supposed to be added during 2

But I do not see it in the feat list after the levelup after

I am running the latest version of the game. I am using Unity Mod manager MM 1

And I think the latest version of the mod MM 2

Here are the logs: logs.zip

I opened the game, loaded a save in Kenabres market, jeveled up Ulbrig one level, and then closed the game.

kpgrimes commented 2 months ago

Hate to say it again, but I'm still unable to replicate it on my end. That being said, I don't have any errors in my GameLogFull about trying to select backgrounds either. Perhaps you have a corrupted game file maybe? You could try verifying your game files in Steam, and see if it replaces/downloads any new files.

Otherwise, I guess I'll just tag @xADDBx and see if he sees anything I missed.

I tried verifying the game files and everything came back clean. I don't know as it's a saved file issue, though, as I can create a brand new game and still run into the issue.

Senior-Sam61 commented 2 months ago

I'm having this issue as well. My game, UM, and toybox are fully updated. I do not have auto level companions on in the game setting, nor do I ignore feat prerequisites on in toybox either.

Just to be clear, I am able to select multiple features, but features that are already on the companion auto level up feature list are showing as already acquired even though they have never been selected. The extra features and backgrounds that were never selected go away once level up is completed.

Example of this would be if you turned the feat multiplier to 3 and level Seelah up to level 3 paladin. She will already show in the feat selection screen that she has acquired Longsword weapon focus even though that was never selected, and you you will be able to select dazzling display. If I select Dazzling Display, intimidating prowess, and persuasive, once I complete the level up and look at my character sheet and I will only have intimidating prowess and persuasive on it. I assume Dazzling display goes away because I never actually met the prerequisites.

xADDBx commented 2 months ago

Just to be clear, I am able to select multiple features, but features that are already on the companion auto level up feature list are showing as already acquired even though they have never been selected. The extra features and backgrounds that were never selected go away once level up is completed.

Sounds like the preview unit might be messed up.
(The following is based on RT, though I assume Wrath works similar) The game doesn't actually use your unit in the level up window. It creates a new unit based on the BlueprintUnit. This Unit will be tested for prerequisites and will be compared against.
In RT I fixed the issue by respeccing the preview unit, though I'm unsure if that's any use here at all.

I've never looked at Feat Multiplier code. Nor will I find any time in the next few days. How is it even implemented?

xADDBx commented 2 months ago
        /**
         * The feat multiplier is the source of several hard to track down bugs. To quote ArcaneTrixter:
         * All story companions feats/backgrounds/etc. most notably a certain wizard who unlearns how to cast spells if your multiplier is at least 8. Also this is retroactive if you ever level up in the future with the multiplier on.
         * All mythic 'fake' companions like Skeleton Minion for lich or Azata summon.
         * Required adding in "skip feat selection" because it broke level ups.
         * Causes certain gestalt combinations to give sudden ridiculous level-ups of companions or sneak attack or kinetic blast.
        */

https://github.com/xADDBx/ToyBox-Wrath/blob/main/ToyBox/classes/MonkeyPatchin/BagOfPatches/LevelUpPatchesWrath.cs#L735

Maybe it needs a proper re-implementation?