Selecting "Duel Swords" category in "Weapons" tab makes Toybox crashed.

cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.

MIT License

160 stars 107 forks source link

Selecting "Duel Swords" category in "Weapons" tab makes Toybox crashed. #1061

Closed BlackburnZZ closed 7 months ago

BlackburnZZ commented 7 months ago

Description of the bug

As title says - Selecting "Duel Swords" category in "Weapons" tab makes Toybox crashed.

Steps To Reproduce

Go to "Weapons" tab Select "Duel Swords" category After that ToyBox crash with errors (but not the game, i mean you can continue to play)

Expected Behavior

No response

Log Files

Player.log GameLogFull.txt

Save File

No response

Screenshots

Error

Settings

No response

Toybox Version

1.5.8

Operating System

Windows 10 x64

What game are you using Toybox on?

Pathfinder Wrath of the Righteous

Game Version

2.2.1a

Anything else?

No response

CasDragon commented 7 months ago

Are you on the main menu when you are getting that error? Because it looks like that, and Toybox has limited functionality on the main menu. While we should probably make the "Enhancement" tab just not load on Main Menu (or we might have already done that), if that errors from the main menu, it's not really an issue

BlackburnZZ commented 7 months ago

Are you on the main menu when you are getting that error? Because it looks like that, and Toybox has limited functionality on the main menu. While we should probably make the "Enhancement" tab just not load on Main Menu (or we might have already done that), if that errors from the main menu, it's not really an issue

No, i've got that error while i'm using ToyBox inside the game(after i loaded save, i mean). For example, "DualAxes" and "DualSwords" categories is working fine. Reset button doesn't do anything,sadly.

xADDBx commented 7 months ago

grafik

BlackburnZZ commented 7 months ago

If I understand it correctly, then I need to add this missing part? Where can I find this file so I can fix this? Sorry, this is just a little new to me. And thank you

BlackburnZZ commented 7 months ago

Update - Also the same problem with "LightMace" category.

xADDBx commented 7 months ago

If I understand it correctly, then I need to add this missing part? Where can I find this file so I can fix this?

Sorry, this is just a little new to me.

And thank you

That was a screenshot of the part of the code where the issue is. It's for either future me or anyone else who'll tackle the problem.

Though if I understand correctly it might be calling the Rating method on a null BlueprintEnchantment which is weird. Nullcheck + return 0 should fix?

BlackburnZZ commented 7 months ago

If I understand it correctly, then I need to add this missing part? Where can I find this file so I can fix this? Sorry, this is just a little new to me. And thank you

That was a screenshot of the part of the code where the issue is. It's for either future me or anyone else who'll tackle the problem.

Though if I understand correctly it might be calling the Rating method on a null BlueprintEnchantment which is weird. Nullcheck + return 0 should fix?

Because I understand absolutely nothing about this, I'll just wait for a future fix :). Thank you anyway for your answers!

xADDBx commented 7 months ago

I can't reproduce the issue. Be sure to verify your game files. Just in case this version should've additional checks against your issue: 0ToyBox0-Wrath.zip

BlackburnZZ commented 7 months ago

I can't reproduce the issue. Be sure to verify your game files. Just in case this version should've additional checks against your issue: 0ToyBox0-Wrath.zip

I did have one corrupted file while verifying the game, but it still didn't solve the problem. But your fix worked! Now both categories are loaded and weapons can be added without problems! Thank you very much!

BlackburnZZ commented 7 months ago

Player.log GameLogFull.txt Update again - now i can't open "Party" tab... (on loaded save. In the main menu i can open it) This worked in the previous version (1.5.8a) and with current fix (1.5.8b) it's not. I apologize for the inconvenience, I don't understand why this is happening. Previously, there were no such problems at all.

xADDBx commented 7 months ago

If you can send over a save I could try and see if the issue is related to that one of these days.

BlackburnZZ commented 7 months ago

If you can send over a save I could try and see if the issue is related to that one of these days. Sure! Manual_780_save_with_ToyBox_1_5_8b___.zip

xADDBx commented 7 months ago

Closed because I just noticed that the resulting thing is probably a different issue