cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.
MIT License
160 stars 107 forks source link

Make Scrolls not counts towards level up spells with Spontaneous Scroll Learning toggle on #1070

Open KengelNeh opened 6 months ago

KengelNeh commented 6 months ago

Description of the bug

Hello. For some reason enabling awesome "Multiple classes on level up" option prevents sorcerers from gaining spells on level up. When i turn it off - spells appears in level up window. It happens even with single-class characters. It works again if you use respec - but in this case sorcerer forgets all spells, that were learned from scrolls (using this mod functionality for such spellcasters). And its not comfortable to use respec each time a character gains a new level. Maybe there is an option to prevent sch things from happening, but i didn't find it. I'm using last patch with all DLC and last version of mod. Problem happened during "Through The Ashes" DLC.

Steps To Reproduce

  1. Make or gain sorcerer (Sendry for example).
  2. Make him learn some spells from scroll (may be optional - don't know).
  3. Level up him while "Multiple classes on level up" option is ON. Sorcerer can have single class or some gestalt classes - problem remains the same.
  4. See no spell selection.
  5. Turn off "Multiple classes on level up" option.
  6. Level up sorcerer one more time - and spells appears. And fore some unknown reasons number of accessible skill points changes.

Expected Behavior

Spells appear during level up for sorcerers.

Log Files

No response

Save File

No response

Screenshots

No response

Settings

No response

Toybox Version

1.5.9

Operating System

Windows

What game are you using Toybox on?

Pathfinder Wrath of the Righteous

Game Version

2.2.3c

Anything else?

I'm using other mods such as Tabletoop tweaks, Isekai mod, Path of Bling and Expanded Content - but this bug is somehow connected to geshtalt option.

CasDragon commented 6 months ago

Can't replicate. Only level I don't get spells known for Sorc is level 2, which is correct, as they don't get any additional spells that level. If you are having this issue on other levels, please provide a save (not an Auto save) and a list of mods that are attached to that save

KengelNeh commented 6 months ago

Hello. Save file in zip-archive attached. List of active mods: Toybox Bubble Buffs Tabletop Tweaks Core Expanded Content Tabletop Tweaks Base Tabletop Tweaks Rework Isekai mod No film grain Tweakable weapon categories VisualAdjustments 2 Path of bling

Manual_538__19_____VIII471523_05_46__.zip

Zakastra commented 2 months ago

I am having similar issues with oracle and hunter in both cases I have been using the spontaneous casters can learn form scrolls option, which was reported as fixed, but still seems to be an issue as far as I can tell

darinclark commented 3 weeks ago

As a side note and possibly relevant comment, if you have your spontaneous casters learn from scrolls, then that can affect how many spells they learn on levelup. Levelup gives them more spells up to whatever limit they should have after the levelup. If they would have gained (say) 2 spells for a spell level and you learned two spells (or more) from scrolls, then they already have as many (or more) spells as they are supposed to have, and they will learn no more.

I cannot say whether this constitutes "working as designed", but this follows a recognizable logic of "give them as many spells as necessary so the character has as many spells as they're supposed to have" - and the number of spells given may be zero.

CasDragon commented 2 weeks ago

Given this context, I was able to replicate the issue. However, like Darinclark mentioned above , I'm fairly certain this is "working as intended" within the code. So... changing to enhancement request, I guess, since this would be a smart enhancement?

xADDBx commented 2 weeks ago

https://github.com/cabarius/ToyBox/pull/923

There's probably no one left who still has contextual knowledge, but I think that PR was supposed to (among other things) implement something like this