search

cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.
MIT License
168 stars 110 forks source link

List of features to add/remove under the party tab refresh everytime add/remove is clicked #1098

Closed RyuKaze78 closed 3 months ago

RyuKaze78 commented 5 months ago

Description of the bug

I have noticed while playing Wrath of the Righteous that when adding features to my character for my umpteenth playthrough that the list refreshes every time to the first page of the results when clicking the add/remove buttons. It did not do this in previous versions. This seems to happen a few minutes after being on the list and can sometimes be bypassed by hitting multiple add/remove buttons quickly. I've tried limiting the results to 100, 300, and 1000 but nothing helps

Steps To Reproduce

  1. Go to Party tab. 2. Click on features arrow to the side of a character's name. 3. Click the show all arrow. 4. Look for a feature or just scroll down the full list. 5. Click the add/remove button

Expected Behavior

No response

Log Files

No response

Save File

No response

Screenshots

no screenshots

Settings

No response

Toybox Version

1.5.10a

Operating System

Windows 10

What game are you using Toybox on?

Pathfinder Wrath of the Righteous

Game Version

No response

Anything else?

No response

CasDragon commented 5 months ago

Can't reproduce on my end. But just to clarify, after you add a feature, the Party tab Features results go from page of the results, to page 1 of the results?

Slightly related, for performance reasons, I will recommend you limit the results to like 50, MAX. I personally have my results limited to 15

RyuKaze78 commented 5 months ago

yeah. If I'm on like page 5 of, say, 10, when I hit the button, it will go back to page 1.

xADDBx commented 5 months ago

I think in the idea is that adding/removing things causes data to change. This could lead to things not being supposed to be on a list anymore (e.g. with Show All deactivated, Removing a feature should remove it from the list).

To avoid having to think about edge cases, adding and removing causes a Browser reload. That's similar to what happens when you change the search query. When that happens the page is automatically set to 1 (since it's assumed that with changed items/different search query you want to start at the beginning)

I don't really see a reason why it should stay on the page. Isn't it more normal to search for something, add on specific result and then search for something else?

Edit: I do want to say that I'm unsure of how exactly it was implemented since @CasDragon mentioned not being able to reproduce it.

xADDBx commented 3 months ago

I finally had some time and had to look at the tab for some time because of another feature

Anyways; the next release will have this fixed