cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.
MIT License
168 stars 110 forks source link

Include Charge Buff, Cleave Buff, Power Attack Buff to Buff Duration Exception. #1116

Closed caloyers closed 4 months ago

caloyers commented 4 months ago

Is your feature request related to a problem?

I cant manually add them in buff duration exception as the search for these does not appear.

Describe the solution you'd like

Add the following to the Buff Duration Exception(Bag of Tricks/Other Multipliers) as this three is hidden in the list.

Charge buff: f36da144a379d534cad8e21667079066 Cleave Penalty Buff(AC Penalty): 914b04c279e3d3447848fecf5796cdcd Power Attack Buff: bfe8300529214c7ca4ae0024f834f085

Charge buff penalty disables activation of stealth mode and even invisibility will trigger an attack from enemies.

Describe alternatives you've considered

No response

Additional context

No response

xADDBx commented 4 months ago

Wait what.

There's buffs that are included but aren't visible in the exclusion editor?

@CasDragon thoughts?

CasDragon commented 4 months ago

I'm like 60% sure those buffs aren't being affected by the Duration Multiplier to being with, which is why it's not showing up in the exclusion editor.

That said, I'm sure it would be fine if we manually added them to the exclusion list, so perhaps we do that, and we'll just call this "fixed"

xADDBx commented 4 months ago

Huuh. I thought we filtered every hidden bp from being multiplied...

Filter for multiplier:

private static bool isGoodBuff(BlueprintBuff blueprint) => !blueprint.Harmful && !badBuffs.Contains(blueprint.AssetGuidThreadSafe);

List of buffs for Exclusion Editor:

_allBuffs = BlueprintLoader.Shared.GetBlueprints<BlueprintBuff>()
                    ?.Where(bp => !bp.IsHiddenInUI
                                  && !bp.IsClassFeature
                                  && !bp.Harmful)
xADDBx commented 4 months ago

Try to see if the new version fixes your issue @caloyers

caloyers commented 4 months ago

Thanks it fixed now. Please close.