Buff Duration Multiplier Issue

cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.

MIT License

165 stars 107 forks source link

Buff Duration Multiplier Issue #768

Closed CasDragon closed 1 year ago

CasDragon commented 1 year ago

Heyyyyyyyy it's your boi Dragon back with another issue from Discord

Describe the bug From Trixter: Folks have been getting that in errors for "permanent" buffs with absurdly high multipliers, It normally doesn't break anything, but I'd like to make it stop erroring when I have a chance

Additional context Trixter wanted a Github issue, so he didn't forget about it.

removed the part of the log file I pasted here because Github doesn't like to format stuff nicely

ArcaneTrixter commented 1 year ago

[ToyBox] [Error] BuffCollection_AddBuff2_patch - duration: 10675199.02:48:05.4775807 - ticks: 9223372036854775807 * 1 => 9.223372E+18 ... [ToyBox] [Error] System.OverflowException: Arithmetic operation resulted in an overflow.

Went and checked the log from discord. Looks like someone is multiplying long.max by a float representation of 1 and then getting back slightly more than long.max. The code has a try-catch around it, so evidently someone knew it was a problem before, and that's why it's not actually causing problems.