cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.
MIT License
167 stars 106 forks source link

Implement support for localization #878

Closed cabarius closed 1 month ago

cabarius commented 1 year ago

Describe the solution you'd like

Implement localization files and allow people from other countries to define localized version of the strings in ToyBox

xADDBx commented 1 year ago

There are already different parts of a localization system in the code; we should use that.

Also, while we do that maybe we can also add a search feature for ToyBox? It gets hard to find something in the more extensive tabs like BagOfTricks

xADDBx commented 1 year ago

Since I can't make a collection PR I'll just use this

Necht commented 1 year ago

Can we somehow help you with localization? My english is not good enough to freely use your very detailed mod. I am not a programmer, but I can help with translation into russian.

LantaVey commented 1 year ago

Hi. The author does not answer anywhere. I would like to get permission to publish a translation into Russian. On this site and on the Nexus. What permissions can I use?

xADDBx commented 1 year ago

Hi. The author does not answer anywhere. I would like to get permission to publish a translation into Russian. On this site and on the Nexus. What permissions can I use?

The author is generally not very active on platforms beside Discord. I did ask her myself after seeing your discussion just now and can probably answer in some time

LantaVey commented 1 year ago

Thank you. Let me know about the results. I am ready to cooperate for translation into Russian. Currently, I have hidden the posted translation on the Nexus.

xADDBx commented 1 year ago

@LantaVey I messaged Narria regarding your query. She answered that she'd come back to you after getting back home. Since it seems that she might've forgotten I mentioned it another time. @Necht thanks for the offer. Sadly, the most pressing work relating to Localization currently is adding the missing .localize() call to all the string which will be displayed. Once those are added, we can then create the final localization key files (which could then be translated). If you take a look at the checklist from my post in this issue, then you will see which tabs have more or less been finished with the calls (since localization has been on the backburner for a while, there might be a few keys missing because something might have changed). If you follow the localization guide you could translate the current keys and have all those keys translated in game. I wouldn't really suggest doing this until all (or mostly all) keys have been added by way of .localize(). And sadly neither I (who has done most of the stuff relating to this) nor Narria (the Maintainer) currently have the time to finish doing all this work since the release of Rogue Trader made other ToyBox related stuff higher priority, and we had some RL stuff to do too (not to mention games like Diablo releasing and being a large time sink). All in all; I can't say when either of us two will find the time to add those, so it's currently more or less in limbo.

LantaVey commented 1 year ago

Good. I understand how busy you are. I just offered to help, if you need it, as a translator for one of the languages. I saw the list above. Most people now would be happy even with what they already have. Many people love your mod, but don't know English. They have to try to poke at random to check what the button does or use a translator that doesn't always work correctly. So I just asked for permission. I checked the translation in the game and it works.

LantaVey commented 1 year ago

I understand. And apparently I can't publish the translation because I didn't get permission. Thank you for your reply. I wish you good luck in implementing your ideas.

Necht commented 1 year ago

Good. I understand how busy you are. I just offered to help, if you need it, as a translator for one of the languages. I saw the list above. Most people now would be happy even with what they already have. Many people love your mod, but don't know English. They have to try to poke at random to check what the button does or use a translator that doesn't always work correctly. So I just asked for permission. I checked the translation in the game and it works.

@LantaVey Привет, судя по всему, мы не скоро увидим их полноценную локализацию на русский язык, а я слишком плохо понимаю английский язык, чтобы полноценно пользоваться этим модом... Поэтому, если не затруднит, можешь пожалуйста скинуть этот мод, переведенный тобой? По крайне мере, для ознакомления с его текущим глобальным функционалом это сильно поможет.

Здесь, наверно, ссылку лучше не оставлять, но, если получится, перешли пожалуйста мне на яндекс почту: let.let.let@yandex.ru

xADDBx commented 1 year ago

@LantaVey I'll tag you since I noticed you might've misunderstood something. The mod maintainer did answer you here. I think they didn't ping you, so you might've missed it.

There's already a translation for Chinese released on Nexusmods. We generally have no problems with translation projects. As mentioned in this thread, we're working on finishing our own localization framework, which would result in translators just having to translate the keys from the localization file. This would be better since even if a new update releases, mod users can still use the most recent version of the mod (even if a small part might be unlocalized).

TL;DR localization file is preferred but unfinished; releasing your own Nexus or whatever version is nevertheless allowed.

I'll try to finish the localization files in the next 2-3 weeks.

xADDBx commented 1 year ago

Just wanted to add an update. Once #1024 is merged, all the keys for the current version (1.5.6) should be in the localization files. Meaning, a full localization is possible by just providing the files with translated keys. Should anyone still find something unlocalized or a missing key in the loc file please feel free to report that to me or another Contributor.

LantaVey commented 1 year ago

I'll try to finish the localization files in the next 2-3 weeks.

I understand. I will wait patiently for your updates. Thank you for your work. And thanks for the permission to translate.

cabarius commented 1 year ago

I support a Russian translation.

xADDBx commented 1 month ago

I'll close this as finished.

I'm not satisfied with the current system, but it does work in its current state and considering WotR is nearing EOL I somewhat doubt anyone will bother rewriting the system.