refactor execute function a bit to be more readable

cabbage-ex / cabbage

Story BDD tool for executing elixir in ExUnit

MIT License

144 stars 34 forks source link

refactor execute function a bit to be more readable #4

Closed shdblowers closed 7 years ago

shdblowers commented 7 years ago

refactor parts of execute function to make it more readable/maintainable.

mgwidmann commented 7 years ago

Awesome, I had planned to get around to doing something like this! I've done a bit of this work that might conflict now in #2 ... Since that has functionality, do you mind upmerging your improvements with that branch?

mgwidmann commented 7 years ago

Hmm on second thought, its dependent upon the gherkin PR so I need to get that one through first... gimme a bit to work that out

mgwidmann commented 7 years ago

I fixed the merge conflicts and merged it, if you have more suggestions or code cleanup (or think my merge was done poorly) please submit another PR. Thanks!

shdblowers commented 7 years ago

thanks @mgwidmann

I think this project will be really useful for me once its complete, so will be happy to contribute more :smile: