Use `scenario` test name instead of `feature`

cabbage-ex / cabbage

Story BDD tool for executing elixir in ExUnit

MIT License

138 stars 33 forks source link

Use `scenario` test name instead of `feature` #76

Closed hauleth closed 5 years ago

hauleth commented 5 years ago

After some thoughts it should suit more to the factual code that is ran.

revati commented 5 years ago

You are completely right. What is odd, is that there are no tests changed? Does it actually change output or behavior, where that :feature vs :scenario ends up making some change?

hauleth commented 5 years ago

@revati there was one test that was problematic, but in #67 I have changed that to accept any name (as long as it do not contain spaces) as older versions of Elixir always used text test here and newer versions use test name defined in ExUnit.register_test/4. And no, we aren't testing for the test names in the summary as it would be hard, because output format for default ExUnit formatter isn't specified at all, so such test could fail between versions