search

cabbage-ex / cabbage

Story BDD tool for executing elixir in ExUnit
MIT License
141 stars 33 forks source link

Allow only one way for importing Gherkin file into tests #77

Open hauleth opened 5 years ago

hauleth commented 5 years ago

IMHO such case should be disallowed, and for defining "helper modules" there should be separate module that would define def* macros.

hauleth commented 5 years ago

Ok, I found that it makes sense. But alternatively I would suggest using only one way to import Gherkin file.

revati commented 5 years ago

Yes it is walid case to have cabbage feature without specified feature file.

But are there multiple ways to import gherkin files? 🤔

hauleth commented 5 years ago

Ok, I have read the code wrongly. But anyway, I would disallow such case and instead force user to always define :file in use, and instead provide separate module with DSL macros.

revati commented 5 years ago

Something like Cabbage.Feature and Cabbage.AbstractFeature?

While I see a benefit to it, it is more like nice to have feature, not must have, it as well might be a 1.1 release, with an extended feature.

Currently, my priority is getting 1.0 out.

And I have too few hours in week I can spend on it :(

hauleth commented 5 years ago

Quick and dirty example how it could work Watermelon.Case and complementary Watermelon.DSL. Example usage of "external step definitions".