search

cabbage-ex / gherkin

A Gherkin file parser written in Elixir. Extracted from https://github.com/meadsteve/white-bread.
11 stars 8 forks source link

Allow Scenarios (or Examples) without description #7

Closed kevdotpub closed 2 years ago

kevdotpub commented 6 years ago

Scenarios without names were just getting silently skipped by the parser which was confusing me somewhat.

Looking at the Gherkin reference (https://docs.cucumber.io/gherkin/reference/#example) it doesn't mention they are required to have names (as it does for Features, for instance). Also, scenarios without titles seem to work well in Cucumber, so I was hoping I'd be alright to make these titles optional?

Whilst in that area, it says that Scenario is really a synonym for Example and either should work so I've added that in this PR too but I'm not bothered about that if you don't want it :)

kevdotpub commented 6 years ago

I just looked into the failing tests and it seems it's from an Elixir version bump in an earlier commit that Semaphore doesn't agree with? I don't think it's related to my code :grin:

revati commented 5 years ago

wanted to merge, but there are conflicts, will have to wait till weekend