search

cabbagejs / cabbage

A CLI for building conventional web applications with Broccoli
MIT License
5 stars 0 forks source link

CSS Minification #29

Closed TravisTheTechie closed 9 years ago

TravisTheTechie commented 9 years ago

CSS now processed through clean-css.

No source map, but getting source maps might be more complicated than I'm feeling like tackling at the moment. With give a shot first though.

TravisTheTechie commented 9 years ago

Also, for #19.

TravisTheTechie commented 9 years ago

And turns out broccoli-concat-cabbage doesn't do sourcemaps yet. So nothing to pass along to clean-css.

searls commented 9 years ago

@TravisTheTechie heads up that broccoli-concat-cabbage is getting yanked as soon as broccoli-concat merges my PR

TravisTheTechie commented 9 years ago

Rebased master so hopefully the CI build will pass.

TravisTheTechie commented 9 years ago

Hmm, I'm now a organization member, but I don't seem to have write permissions to this repo. It still says

This pull request can be automatically merged by project collaborators. Only those with write access to this repository can merge pull requests.

searls commented 9 years ago

Fixed that -- you were in the org but not on this repo b/c teams.

searls commented 9 years ago

hey before we merge this, let's write a test for the CSS

searls commented 9 years ago

actually forget that i don't have access to your repo. i'll merge and then do it