search

cabbagejs / cabbage

A CLI for building conventional web applications with Broccoli
MIT License
5 stars 0 forks source link

Adding uglifyJS into the JS pipeline. #31

Closed TravisTheTechie closed 9 years ago

TravisTheTechie commented 9 years ago

Tests aren't passing yet, so waiting until those pass and I'll rebase.

TravisTheTechie commented 9 years ago

Fixes #17.

searls commented 9 years ago

Yeah they're passing now, you can go ahead and rebase. I had failed to push up cabbage-cli, which had been changed to make the tests work

TravisTheTechie commented 9 years ago

Hmm, so one failure was easy to fix, but it doesn't look like the addFile is working right or that the pipeline is picking up the new file.

searls commented 9 years ago

are you running/testing these locally and passing?

TravisTheTechie commented 9 years ago

Running locally but not passing. Found the tmp directory, I'm attempting to dig into it there to see what's going on.

TravisTheTechie commented 9 years ago

Duh. Timing issue. Initially (done) -> build(done) is done before I add the file.