search

cabernetwork / cabernet

Cabernet allows control of IPTV streams. Plugins supports DaddyLive, Pluto TV, XUMO, M3U/XMLTV.XML files (SamsungTV, STIRR, DistroTV, Plex TV)
https://cabernetwork.github.io
MIT License
154 stars 22 forks source link

Changed ' to ", to fix m3u/m3u8 list specific to Jellyfin loading m3u… #141

Open slippyC opened 5 months ago

slippyC commented 5 months ago

… lists.

For some odd reason Jellyfin doesn't like ' around data it prefers ". Also changed channelID to channel-id. I see this more commonly and it also uses that id in the epg/xmltv files.

This should help deal with guide data and loading icons for channels without going in an actually mapping channels in Jellyfin.

rocky4546 commented 5 months ago

channelID is found in other files and will need to be addressed before applying this PR. The rest looks good.

slippyC commented 5 months ago

Alrighty, I'll change it over. It won't effect any of the stuff I use. I have never seen it as ChannelID in another .m3u file. Anyway, will change it over.

rocky4546 commented 5 months ago

You missed what I said. I did not say to change what you did, but rather, you missed other spots. If we are going to assume that channelID is now channel-id, it needs to change in other files as stated above. Only changing half the spots makes no sense to me.

slippyC commented 5 months ago

I see, I misunderstood what you were asking. I'll have to go through the files and figure it out then. If you want to commit that as a fix for current stable Jellyfin, then go for it. If you want to wait for me to go through the files, I don't know how long that will take; because I don't know all the references of where it is used(yes, I can do a project wide search; but still have to make sure how it's referenced).

All I do know is the current stable version of Jellyfin doesn't work right with the way it is currently(you will have to manually map). I was about to pull my hair out trying to figure out why the guide wasn't populating and why channel icons weren't showing up(even though the logs said there was guide data found). I was first looking at the EPG files to see if id's weren't correlating. Also tried to remove channel name duplicates, multiple names for same channel. I didn't think that that should have an impact on the two being tied together, since it really depends on the ids between m3u and xmltv files.

slippyC commented 5 months ago

You missed what I said. I did not say to change what you did, but rather, you missed other spots. If we are going to assume that channelID is now channel-id, it needs to change in other files as stated above. Only changing half the spots makes no sense to me.

After last response I did have time to do a project wide search. This is only place that is referenced. I also did a search for some of the other m3u elements just to see if they would pop up, but it looks as if they are only referenced when writing to the m3u file/stream(in that part of code).