search

cabernetwork / cabernet

Cabernet allows control of IPTV streams. Plugins supports DaddyLive, Pluto TV, XUMO, M3U/XMLTV.XML files (SamsungTV, STIRR, DistroTV, Plex TV)
https://cabernetwork.github.io
MIT License
179 stars 24 forks source link

[Feature Request] Insert an opt-in (default disabled) visual indicator in stream to show looping clip that says "adblock in progress" for supported providers (such as PlutoTV) #160

Closed successtheman closed 3 weeks ago

successtheman commented 1 month ago

I thought about this over the past few months while using cabernet and it would definitely make it more friendly to the end user to also show a visual indicator within the actual stream from cabernet in the form of a looping clip during adblock, for Pluto TV for example. The kind of clip I am referring to is what you might see when TV networks have finished their scheduled commercials yet still haven't finished the commercial break. An example is this video for AT&T https://www.youtube.com/watch?v=4jJqm1D8zNM (there are all sorts of them if you look around).

I don't know if this is something simple to do, but if you need help creating a clip to loop during the times when ads are being blocked I could help make one. Hopefully others may agree that this would be a useful addition to the program. Since I am not very well versed in the development of cabernet, I could be wrong but it seems like you could add this to the ad blocking functions and have it play the video when adblock kicks in.

As mentioned here https://github.com/cabernetwork/cabernet/issues/160#issuecomment-2307946058 it should also not be enabled by default but be an option users can enable if they choose, this way long time users of cabernet are not adversely impacted.

stale[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

successtheman commented 3 weeks ago

bumping this

cookieisland commented 3 weeks ago

Please do not do this.

the whole idea behind not streaming anything when there is a commercial is so when we record a show the commercials 'disappear'. If a video is played during the commercial then we have to watch it later on playback. Ie the current configuration is good asis.

On Thu, Aug 22, 2024, 9:31 PM successtheman @.***> wrote:

bumping this

— Reply to this email directly, view it on GitHub https://github.com/cabernetwork/cabernet/issues/160#issuecomment-2306246740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWA76TX5UGEHAHZEETQ6ETZS23JPAVCNFSM6AAAAABMEYOOHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGI2DMNZUGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

successtheman commented 3 weeks ago

Please do not do this. the whole idea behind not streaming anything when there is a commercial is so when we record a show the commercials 'disappear'. If a video is played during the commercial then we have to watch it later on playback. Ie the current configuration is good asis. … On Thu, Aug 22, 2024, 9:31 PM successtheman @.> wrote: bumping this — Reply to this email directly, view it on GitHub <#160 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWA76TX5UGEHAHZEETQ6ETZS23JPAVCNFSM6AAAAABMEYOOHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGI2DMNZUGA . You are receiving this because you are subscribed to this thread.Message ID: @.>

it can be disabled by default and users can enable it if they choose, I didn't say to enable it by default, and if it's not enabled by default what's the problem? As for recording, I can never ever consistently record with this so I don't even bother.

I think this is a welcomed addition as long as it is not enabled by default so it doesn't interfere with setups of people who are long time users but would also benefit people who use it to just view livestreams if they want to enable it.

rocky4546 commented 3 weeks ago

It's actually not possible unless you fully rewrite the entire stream with new DTS type data and that would be an extremely major issue. If the person writing the issue wants to do it and write a PR with updated the ATSC 1.0 data segments, be my guest.

successtheman commented 3 weeks ago

It's actually not possible unless you fully rewrite the entire stream with new DTS type data and that would be an extremely major issue. If the person writing the issue wants to do it and write a PR with updated the ATSC 1.0 data segments, be my guest.

Unfortunately I have no idea what any of that means so I guess that means it's not simple to do and I likely will not be able to do it myself. No worries anyway, was just a suggestion if it was simple to do.

rocky4546 commented 3 weeks ago

Yea, we did look into this a while back. To give you some insight... PlutoTV just slams a video stream (ad) into the mix causing the issues with the playback, so we remove them. The thought of reintroducing un-synced video would cause the same issue plutotv currently has with players. They have created there own player that you must use in order to get around the "just stick video in the middle" concept. To understand the issue, you need to understand ATSC 1.0. First, a packet in ATSC 1.0 is 188 bytes. Near the start of each stack is a counter. If packets are added to the stream, then the counter will need to be re-sequenced through the entire stream. On top of that, the video and audio also have independent counters called the DTS. This gives the player a way to sync up the audio with the video. If you just plug in new video, then the DTS will have a major disconnect and players will have lots of issues. So, to fix this, the DTS also has to be re-sequenced for both the audio and video segments. ffmpeg is suppose to have the ability to resync the segments, but they have that code so messed up, it does not do the job most of the time.