search

cabforum / build-guidelines-action

Action to build Pandoc-flavored Guidelines into their final form
0 stars 3 forks source link

Tests are non-deterministic #11

Closed sleevi closed 3 years ago

sleevi commented 3 years ago

Despite thinking I'd fixed it, there's still issues with set +x ordering in the broken links output, which can end up ordered before or after the echo "::endgroup::" command. The consequence of this is that it causes tests to fail intermittently, both locally and on the GitHub infrastructure.

A proper fix for this looks to be fairly simple: use {set +x } 2>/dev/null to use a sub-shell that redirects the xtrace output to /dev/null

sleevi commented 3 years ago

So, still happening. It's likely because of the direct pipe to diff, causing stdout to be buffered, while stderr isn't. Previously, this triggered with the set +x command, but this could also be triggered by the pandoc commands (which, because of the set -x, are being echoed to stderr).