search

cabforum / build-guidelines-action

Action to build Pandoc-flavored Guidelines into their final form
0 stars 3 forks source link

Pin the TeX Live version to 2020 #21

Closed sleevi closed 3 years ago

sleevi commented 3 years ago

Until we get GitHub Containers setup, we end up building the Docker image on every run, which means that the action depends on external servers and services (unfortunately). TeX Live has updated to 2021, which means that the current image base is out of date.

Updating Pandoc should also resolve this (by virtue of updating the version of TeX Live in the base image, which we inherit from the Pandoc base image), but in the interim, pin the version of TeX Live to the 2020 repository to reflect what we're doing.

Fixes #20

sleevi commented 3 years ago

@aarongable @castillar @wthayer If someone would like to safety check and/or offer alternatives.

Long-term, publishing the container via GitHub Container Registry will fully avoid this, but we haven't done that yet due to the PAT token dependency meaning a Bot account is preferable/necessary, and we haven't setup an email alias for the bot account :)

sleevi commented 3 years ago

Yeah, turns out GitHub now supports GITHUB_TOKEN for GHCR, so I put together https://github.com/cabforum/build-guidelines-action/pull/22

I’m going to go ahead and land this as an immediate fix, and update the tag, which will keep things building for folks, as SC41 lands.

I’ll then finish testing #22 as an integration, so then we can swap out the action URLs to the Docker image.