Closed armenr closed 5 years ago
@niftylettuce - Any chance you can throw us an assist? Else, we might have to find a different logger solution, and we love cabin :(
I prob just need to replace that package with different solution, will try to find time today
Thanks Mr. Lettuce! @niftylettuce
If it helps at all, see this: - https://github.com/pnpm/pnpm/issues/1979
@niftylettuce - I may have been wrong in my assumption.
There's some kind of weirdness with the packages *-x
packages being used - and their dependency graphs - but I was able to work around it.
I figure anyone using npm or yarn should be okay, but I'm done trying to figure it out specifically, as it is neither your problem, or mine. I use pnpm and --shamefully-flatten
this to get it to work now...after removing some other dependencies I wasn't using in that particular microservice.
@armenr Please try the latest Cabin version v5.0.0. I've upgraded its child dependency of Axe to v4.0.1 and optimized it a bit. You should no longer get any warnings about inspect-x
or any other -x
affixed packages as I've dropped that dependency util-format-x
completely as it's not needed. Let me know if it works on your end after upgrading!
P.S. I had to do a major version bump because util-format-x
allowed you to do util.format
similar to Node in the browser (e.g. you could do %O
format specifier). I switched util-format-x
to use https://github.com/tmpfs/format-util instead, which is a way more lightweight and less complex alternative for the browser - and as such this was a major change (albeit probably nobody uses it for format specifiers in the browser since that's pretty much just a Node thing). At the least we can still use %s
, %d
, %%
, and %j
for now in the browser 😄
cc @zkochan
For more insight into my "P.S." line above, see this section from the Axe docs:
You can also use format specifiers in the browser (uses
format-util
– has limited number of format specifiers) and Node (uses the built-inutil.format
method – supports all format specifiers). This feature is built-in thanks to smart detection usingformat-specifiers
.
Hi there - oddly, I'm getting this error when using pnpm packager in place of npm. In any case, what I was able to figure out was that the util-format-x dependency version in axe appears to be really, really old...and from what I can tell, that's what's causing this. When I disable cabin, everything works fine.
Any help or suggestions would be much appreciated.
Thank you!