Closed rhythnic closed 5 years ago
I can tell you why it succeeds. Cause the way the apis are structured, it would return 200 cause the local DB added the applicatioNTL but put a log in the response for the fact that the LoRa failed. It still based the response on the local db not the network call, which needs to be changed but that is how it is currently
What does this PR do?
Do you have any concerns with this PR? No
How can the reviewer verify this PR? Run tests
Any background context you want to provide?
A POST to applicationNetworkTypeLink was succeeding, despite the POST to /api/applications on LoRa Server failing. The application name/description etc. wasn't being submitted in the "addApplication" method. I fixed that, so that the POST to LoRa succeeds, but I didn't debug the reason why applicationNetworkTypeLink succeeded. I'm not sure how the backend e2e tests are succeeding. Looking at the tests, they check for the app name, but from what I saw in the code, the name wasn't being sent over. I don't know. I must be missing something. Anyway this fixes the inability/errors for creating an app in the UI.
Screenshots or logs (if appropriate)
Questions: