Replace nconf with json-schema based config. - Githubissues

cablelabs / lpwanserver

LPWAN Provisioning & Management Server

https://lpwanserver.com

Apache License 2.0

37 stars 11 forks source link

Replace nconf with json-schema based config. #270

Closed rhythnic closed 5 years ago

rhythnic commented 5 years ago

What does this PR do?

Replace nconf with a custom config setup using JSON Schema.

Do you have any concerns with this PR?

No

How can the reviewer verify this PR?

View

Any background context you want to provide?

The reasons for doing this are:

schema for conifg with type, description, defaults, validation properties all in one place
config can be validated to ensure all required config props are passed in
type info is used to convert the strings received from process.env (environment variables)
better separation of config defaults and development settings

Screenshots or logs (if appropriate)

Questions:

Have you connected this PR to the issue it resolves? #257
Does the documentation need an update? Yes, docs site config section needs updated
Does this add new dependencies? ajv
Have you added unit or functional tests for this PR? no