issues
search
cablelabs
/
lpwanserver
LPWAN Provisioning & Management Server
https://lpwanserver.com
Apache License 2.0
37
stars
11
forks
source link
Issue 276
#281
Closed
rhythnic
closed
5 years ago
rhythnic
commented
5 years ago
What does this PR do?
Fix 2 bugs in TTN
TTN class wasn't extending NetworkProtocol class
TTN id creation didn't ensure that ID doesn't end with dash or underscore
Remove TTN and Loriot credentials from tests into environment variables
Ensure tests pass with TTN enabled
Do you have any concerns with this PR? No
How can the reviewer verify this PR? View
Any background context you want to provide?
Screenshots or logs (if appropriate)
Questions:
Have you connected this PR to the issue it resolves? #276
Does the documentation need an update? No
Does this add new dependencies? No
Have you added unit or functional tests for this PR? No
What does this PR do?
Do you have any concerns with this PR? No
How can the reviewer verify this PR? View
Any background context you want to provide?
Screenshots or logs (if appropriate)
Questions: