Replace all instances of LoRa Server with ChirpStack

cablelabs / lpwanserver

LPWAN Provisioning & Management Server

https://lpwanserver.com

Apache License 2.0

39 stars 11 forks source link

Replace all instances of LoRa Server with ChirpStack #353

Closed luketainton closed 4 years ago

luketainton commented 4 years ago

What does this PR do?

This PR replaces all instances of 'LoRa Server' in the docs with 'ChirpStack'.

Do you have any concerns with this PR?

No.

How can the reviewer verify this PR?

Check through the changes to ensure they are happy with all replacements.

Any background context you want to provide?

Fixes #345

Questions:

Have you connected this PR to the issue it resolves? Yes - #345
Does the documentation need an update? This PR is updating the docs.
Does this add new dependencies? No.
Have you added unit or functional tests for this PR? Not neccessary.

luketainton commented 4 years ago

Hi @rhythnic ! I've implemented these changes for you - please check through them to make sure I haven't missed anything :)

UPDATE: It would seem that something has broken the Travis build :/

rhythnic commented 4 years ago

I forgot that we'll need to update "Lora Server" to "Chirpstack" in the tests. If you do a search/replace, case insensitive, from "Lora Server" to "Chirpstack" for the whole test directory, it should fix it. If not, update the PR to merge into issue-345 and I will take care of running/fixing the tests locally. Thanks for all your help.

rhythnic commented 4 years ago

Thanks @luketainton . I'll merge this Monday and publish the new documentation.

luketainton commented 4 years ago

Always happy to help @rhythnic 👍