search

cablelabs / snaps-boot

Linux install and network setup for SNAPS
Apache License 2.0
13 stars 11 forks source link

WIP - 18.04 #268

Closed bo-quan closed 5 years ago

bo-quan commented 5 years ago

What does this PR do?

Do you have any concerns with this PR?

How can the reviewer verify this PR?

Any background context you want to provide?

Screenshots or logs (if appropriate)

Questions:

bo-quan commented 5 years ago

Code appears reasonable for installation of Ubuntu 18, but what if we require 16?

Good point. I created #275 to track this requirement (as well as running concurrent CI jobs to verify both 18.04 and 16.04 for PR commits.)

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

@spisarski I'm going to abandon this one (due to lots of rebase conflicts) and create a new cleaner PR for review and merge.