Aws ci - Githubissues

cablelabs / snaps-boot

Linux install and network setup for SNAPS

Apache License 2.0

13 stars 11 forks source link

Aws ci #273

Closed bo-quan closed 5 years ago

bo-quan commented 5 years ago

What does this PR do?

Add AWS based CI. Also changed to use spot instances to save 3/4 of cost compared with on-demand instances.

Do you have any concerns with this PR?

No

How can the reviewer verify this PR?

Trigger CI by adding "Run Tests" comment to PR.

Any background context you want to provide?

No

Screenshots or logs (if appropriate)

Questions:

Have you connected this PR to the issue it resolves?

272
Does the documentation need an update? Included README for CI.
Does this add new Python dependencies? No
Have you added unit or functional tests for this PR? No
Does this patch update any configuration files? No

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Run Tests

bo-quan commented 5 years ago

Only one change to ensure developers run without waiting. I believe no wait should be default and waiting should be triggered via CI only via a command line argument.

I'm not setting the max spot price so no wait is planned. The worst case is on demand price, but typically the spot price is 1/4 of on demand price.