Fixes #243
Improves the CI validation code and fixes Rook validation as things had changed upstream causing the current validation routines not testing anything with regards to Rook.
Do you have any concerns with this PR?
no
How can the reviewer verify this PR?
Manually check to see if Rook is running after CI deployment???
Any background context you want to provide?
Screenshots or logs (if appropriate)
Questions:
Have you connected this PR to the issue it resolves?
yes
Does the documentation need an update?
no
Does this add new Python dependencies?
no
Have you added unit or functional tests for this PR?
Fixed some
Does this patch update any configuration files?
no
spisarski
commented
5 years ago
What does this PR do?
Fixes #243 Improves the CI validation code and fixes Rook validation as things had changed upstream causing the current validation routines not testing anything with regards to Rook.
Do you have any concerns with this PR?
no
How can the reviewer verify this PR?
Manually check to see if Rook is running after CI deployment???
Any background context you want to provide?
Screenshots or logs (if appropriate)
Questions: