Fixes #245 Sort of
It begins to address the problems outlined in #245 but is really meant to address issues elsewhere driving from installation of snaps-kubernetes on nodes imaged by snaps-boot behind an http proxy
Do you have any concerns with this PR?
It still does not fully address why nodes with 2 configured EC2 network interfaces continually fails to deploy properly; however, the existing use cases and the ones required by this fix work fine.
The kubernetes.api_server optional config is really unclear as the value required by k8s appears to be the IP of the last NIC which is really strange but I'm going with it for now.
How can the reviewer verify this PR?
run ci
Any background context you want to provide?
Screenshots or logs (if appropriate)
Questions:
Have you connected this PR to the issue it resolves?
yes, but there should be an addendum prior to merging
Does the documentation need an update?
most likely but there is some for the new optional config attribute
Does this add new Python dependencies?
no
Have you added unit or functional tests for this PR?
no but I have expanded the CI environment so we can being triaging the issues with multiple configured EC2 nics.
Does this patch update any configuration files?
kubernetes.api_server optional config was added
What does this PR do?
Fixes #245 Sort of It begins to address the problems outlined in #245 but is really meant to address issues elsewhere driving from installation of snaps-kubernetes on nodes imaged by snaps-boot behind an http proxy
Do you have any concerns with this PR?
It still does not fully address why nodes with 2 configured EC2 network interfaces continually fails to deploy properly; however, the existing use cases and the ones required by this fix work fine. The kubernetes.api_server optional config is really unclear as the value required by k8s appears to be the IP of the last NIC which is really strange but I'm going with it for now.
How can the reviewer verify this PR?
run ci
Any background context you want to provide?
Screenshots or logs (if appropriate)
Questions: