Snaps interface openstack

shishirgoenka commented 6 years ago

What does this PR do?

This PR create a separate br-ex network configuration file during the deployment of openstack. On cleanup br-ex.cfg is removed from the /etc/network/interfaces.d folder and target hosts are rebooted to fallback to static network configuration.

Do you have any concerns with this PR?

No

How can the reviewer verify this PR?

by deploying and cleaning openstack setup

Any background context you want to provide?

NA

Screenshots or logs (if appropriate)

Questions:

Have you connected this PR to the issue it resolves?
150 and #156
Does the documentation need an update? yes
Does this add new Python dependencies? No
Have you added unit or functional tests for this PR? No
Does this patch update any configuration files? No

shishirgoenka commented 6 years ago

Regarding the issue on kola_toolbox, We have checked the CableLabs setup and found that pull_from_hub was set as “no”. It seems that there is some issue in the kolla opensource code with kolla_toolbox, because of which deployment is failing.

We suggest you to please change the pull_from_hub tag to “yes” and re-deploy the openstack. Please try with this change, and let us know if still the deployment is failing.

Also, apart from kolla_toolbox issue, there was some other issue seen in cleanup of the interface file, which we have checked in in this pull request.

shishirgoenka commented 6 years ago

@RandyLevensalor PR has been updated as per the requested changes

RandyLevensalor commented 6 years ago

We have decided to postpone and re-work this patch at a later date. Closing this PR and leaving the branch and issue open.

cablelabs / snaps-openstack