search

cablelabs / snaps-openstack

OpenStack installer for SNAPS
Apache License 2.0
9 stars 10 forks source link

Support of overlay2 storage driver #200

Closed chiraggupta06 closed 6 years ago

chiraggupta06 commented 6 years ago

What does this PR do?

This PR provides support of overlay2 storage driver

Do you have any concerns with this PR?

No

How can the reviewer verify this PR?

By deploying OpenStack

Any background context you want to provide?

No

Screenshots or logs (if appropriate)

NA

Questions:

spisarski commented 6 years ago

@skulasekar, can you look at the CI runtime snaps-oo version. I believe it needs to be updated as per the CI console logs.

spisarski commented 6 years ago

Run Tests

spisarski commented 6 years ago

Run Tests

RandyLevensalor commented 6 years ago

Run Tests

RandyLevensalor commented 6 years ago

I'm not sure why this failed on CI. But we should get it to pass before merging.

The rest of the patch looks good.

RandyLevensalor commented 6 years ago

Run Tests

bo-quan commented 6 years ago

Run Tests

bo-quan commented 6 years ago

The CI test has been running for 10 hours without a result, Bo will check the CI issue.

skulasekar commented 6 years ago

Run Tests

bo-quan commented 6 years ago

Run Tests

bo-quan commented 6 years ago

CI had a file copying permission failure, working to resolve the issue currently blocking the ci to run.

skulasekar commented 6 years ago

Run Tests

skulasekar commented 6 years ago

Run Tests

bo-quan commented 6 years ago

Run Tests

bo-quan commented 6 years ago

Run Tests

bo-quan commented 6 years ago

@RandyLevensalor The CI was originally passed for this PR (http://54.214.227.244:8080/job/snaps-openstack/97). I think some issues were introduced since then which is not related to this PR. Any objections merging this PR?

bo-quan commented 6 years ago

We decide to merge this PR after today's call.