cablelabs / snaps-openstack

OpenStack installer for SNAPS
Apache License 2.0
9 stars 10 forks source link

Changes for compatibility with Ansible > 2.4, fixes for #211 #210

Closed platini2 closed 5 years ago

platini2 commented 6 years ago

What does this PR do?

Makes snaps-openstack to work with ansible > 2.4

Do you have any concerns with this PR?

Testing with other versions different than 2.7.2 of ansible

How can the reviewer verify this PR?

Install ansible 2.7 and run

Any background context you want to provide?

Screenshots or logs (if appropriate)

Questions:

bo-quan commented 6 years ago

@platini2 I agree with @spisarski, especially due to the vulnerability issue with ansible version <2.4.5 (see https://github.com/cablelabs/snaps-openstack/issues/206)

platini2 commented 6 years ago

Ok, so if we agree that, I can remove all the logic to be backward compatible to support ansible < 2.4

platini2 commented 6 years ago

reverted previous commits and included changes in a single commit to make it compatible with ansible > 2.4 and require ansible over 2.4.5

platini2 commented 5 years ago

There are some other pep8 failures but not on the files that I changed in this commit.

RandyLevensalor commented 5 years ago

@spisarski @bo-quan It looks like the pep8 issues were introduced in a different PR. Can we approve this PR, since it didn't add the pep8 issues?