search

cablelabs / snaps-openstack

OpenStack installer for SNAPS
Apache License 2.0
9 stars 10 forks source link

Renamed top-level package name from snaps-openstack to snaps_openstack. #46

Closed spisarski closed 6 years ago

spisarski commented 6 years ago

Python package names cannot contain a '-' character.

I cannot verify this patch has not broken anything

chriscorcimiglia commented 6 years ago

@spisarski can you please update references in install.md that may be broken with the name change? Or at least verify that there are none.

chriscorcimiglia commented 6 years ago

@spisarski I'm good with merging this now and then doing the testing once the remainder of pep8 updates have been made. I just realized that this was only the beginning of the pep8 changes for #26

spisarski commented 6 years ago

@RandyLevensalor, the contents are identical. I don't know why these files weren't simply moved like the rest...

chriscorcimiglia commented 6 years ago

@RandyLevensalor and @spisarski When you look at the actual file changes that are being shown in those files in question, the before content and the after content are exactly the same. Not sure what happened to make GitHub show them as changes, but I think they are fine to merge.

chriscorcimiglia commented 6 years ago

So I think the decision is to re-do this PR after #47 has been merged. Hopefully some of the file change confusion will no longer be an issue with the new PR as well. @spisarski I'm going to close this PR.