cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

Can't open Patch after deleting OP from the website #648

Closed tiagomelobr closed 9 months ago

tiagomelobr commented 10 months ago

Describe the bug I'm not able to open my patch after deleting an OP it used.

How To Reproduce

  1. Open any Patch
  2. Duplicate it using the global namespace
  3. Go to My Data, Ops, click manage on the specific OP, and delete it
  4. Try to open the Patch again

Platfowm

steam0r commented 10 months ago

hey,

how did you manage to delete the op? did you not see this warning?

Bildschirmfoto 2024-01-02 um 11 54 32

thanks!

tiagomelobr commented 10 months ago

Hey @steam0r,

hm, that's strange. I'm not sure, I believe the delete button was also in there. The warning is buggy with a white background, I might have missed the warning.

image

It would be nice just to have a try/catch when loading the OPs, this way people wouldn't lose access to the Patch if something like this happens.

hey,

how did you manage to delete the op? did you not see this warning?

Bildschirmfoto 2024-01-02 um 11 54 32

thanks!

steam0r commented 10 months ago

yeah, we are thinking about showing the warning/error but loading the patch anyhow so you can still recover and fix whatever is broken. the only way i could reproduce your behaviour was by copypasting a deleted op to an already open patch though...not sure if that is how you got into this mess...would be interesting to know how to reproduce.

am i getting you right in that you are using "light theme" for the website and the errors/warnings look like in your screenshot? if thats the case, we will definitely look into this. anyhow, IF that warning is show, even if unreadable, the delete button is not on the page...so...interesting :)

pandrr commented 9 months ago

bright theme is repaired and it should look fine. delete button label is not more clear that stuff is REALLY permanently deleted.