search

cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

Create sub-patch from selection not working #808

Open pixtur opened 4 months ago

pixtur commented 4 months ago

Link to simple, reproducible example patch Please check the following screen capture:

Describe the bug

  1. Input ports are not correctly created (number ports missing)
  2. There are multiple input/output areas which looks like a bug but might be be design.
  3. The position of input/output areas and the operators should be closer together (I actually think that the original op position should be ignored)
  4. Sadly the port-edit UI is not shown in sub patch settings.

Platform cables.dev Chrome / Win10

Console log:

dev.cables.gl-1721824746200.log

pixtur commented 4 months ago

https://github.com/user-attachments/assets/7e71ec46-563f-4a25-9629-8f2f46ca90e5

pixtur commented 4 months ago

The issue with missing number connects was caused by an incorrect order of operators (it's hard to see but after I created a second input on the port that was already taken).

After moving the op it's more obvious: image

pixtur commented 4 months ago

After grouping this, the ports are created, but sadly not connected:

image

pixtur commented 4 months ago

Note to self: The port edit UI is shown when...

  1. the sub patch is NOT open
  2. a sub patch instance is selected
  3. In the parameter window click the icon next to Documentation (Doesn't have a tooltip, so not sure what it's called)