search

cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

TriggerOnChangeNumber does not work as expected #814

Closed pixtur closed 3 months ago

pixtur commented 3 months ago

Link to simple, reproducible example patch

Uploading DEV Car With Navigation - Google Chrome 2024-07-25 15-08-14.mp4…

Describe the bug The name of the operator implies that it triggers (once) when the number changes. In fact it triggers (always) if the number port get invalidated (executed after being dirty) even if the number in fact does NOT change. I assume that other people will also fall into that trap.

I recommend to rename this one to [TriggerIfNumberIsDirty] and create a new [TriggerOnNumberChanged]. This new operator should also have an epsilon or threshold parameter.

Platform dev.cables / Win10 / Chrome

pandrr commented 3 months ago

no this is not true, it only triggered when changed

pixtur commented 3 months ago

I'm sorry. I forgot the attachment.

https://github.com/user-attachments/assets/53c3da39-0910-4484-8a3b-d6fa25d9e897

pandrr commented 3 months ago

there are more values set then the ui can display. can you connect the vizlogger op and see all the values that are being set?