search

cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

Multiple SubPatchInput and SubPatchOutput ops #831

Open TobyKLight opened 3 months ago

TobyKLight commented 3 months ago

Link to simple, reproducible example patch https://cables.gl/edit/trFWVl

Describe the bug Say you have two nested subpatch ops. The outer subpatch is A and the inner subpatch is B. When you refresh the patch then subppatch A will have multiple sets of SubpatchInput and SubpatchOutput ops

How To Reproduce

  1. Open https://cables.gl/edit/trFWVl

  2. Already you should see the result of this bug if you go into 'MySubpatch'

    image

  3. Delete the erroneous SubpatchInput and SubpatchOutput ops

  4. Save and refresh the patch

  5. Again go into MySubpatch and notice the erroneous ops are back

Platform Chrome 127 on win 11 Tested on regular and dev cables.

TobyKLight commented 3 months ago

Note I can see a usecase in future for multiple SubPatchInput and Output ops where you intentionally use them to distribute your inputs around the patch which makes your connections neater (vvvv gamma style). But this is not a function like that, the extra ops here are definitely unwanted.

pandrr commented 3 months ago

on dev.cables.gl:

hopefully those will not be generated in the future but you will have to delete them manually once

steam0r commented 2 months ago

this is now on cables.gl