search

cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

Adding a port to a subpatch op clears unsaved work #835

Open TobyKLight opened 2 months ago

TobyKLight commented 2 months ago

Link to simple, reproducible example patch https://cables.gl/edit/QKMc9n

Describe the bug Adding a port to a subpatch op clears unsaved work. This is often annoying because halfway through patching the op internals you realise you need another port, hence you don't think to save first.

Fix would be if it automatically saved subpatch internals before it added the port.

How To Reproduce

  1. Open https://cables.gl/edit/QKMc9n
  2. Double click MyCustomOp and go inside
  3. Create a new op of any kind but do not save the op
  4. Go back to the outer context, click MyCustomOp and add a port using the left dialog
  5. Now go back inside MyCustomOp and notice whatever you added at step 3 is gone

Platform Chrome 128 on win11

pandrr commented 2 months ago

dev.cables.gl has a huge subpatchop update, subpatchops are saved automatically after creating the port.

steam0r commented 3 weeks ago

this is now on cables.gl!