search

cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

Resetting CompArray is not detected by either PointCloudFromArray or SimpleSpline #852

Open esperanc opened 2 months ago

esperanc commented 2 months ago

Link to simple, reproducible example patch https://cables.gl/edit/QMjqNn

Describe the bug An array which becomes empty is not handled correctly by PointCloudFromArray and SimpleSpline

How To Reproduce Run the provided example patch, click and draw the mouse over the canvas to produce a bunch of points which are stored in the CompArray op. Now click the right mouse button. The drawing should be cleared, since the array now has 0 points. The test compares 4 methods for drawing primitives defined from a point array, which can be selected from the SideBar:

  1. Iterating the array with an Array3Iterator and producing circles
  2. Points produced with PointCloudFromArray
  3. SimpleSpline
  4. SplineMesh

1 and 4 handle this correctly, but 2 and 3 don't.

Platform Google Chrome on a MacBook

Dev Tools Nothing relevant there.

pandrr commented 2 months ago

thanks for the report. this is now fixed on dev.cables.gl

steam0r commented 3 weeks ago

this is now on cables.gl!