search

cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

Breadcrumbs take you into an op instead of select it in its outer context #856

Open TobyKLight opened 2 months ago

TobyKLight commented 2 months ago

The 'breadcrumbs' UI is very useful, but I find it a little difficult to use because it works differently to how I expect.

image

Currently clicking on a breadcrumb takes you OUTSIDE the op to the outer context of that op and selects the op itself.

Feature Request

Request is to make the breadcrumbs work as per many other applications where clicking on a breadcrumb takes you INTO that item. Maybe a small additional button could be added (The final '>'?) that does the select the item function.

image

For example on the top left of github there are navigation breadcrumbs. If I click cables_docs I see the contents of cables_docs. Not the outer context of cables-gl repos with the cables_docs repo selected.

image

Or in windows it's the same. If l click 'Gigs' I see the contents of Gigs folder

pandrr commented 2 months ago

i changed this, because i often needed to go to the op of the current subpatch. probably only the last "current" one should act like that and all others go inside of their parent subpatch...

pandrr commented 2 months ago
Screenshot 2024-09-16 at 18 01 49

this is now on dev, i am still not 100% happy with it. but i need the functionality to go to the op all the time. maybe the last one should be visualized differently or have an icon or something... not sure

TobyKLight commented 2 months ago

Thanks for the change. This already works a lot better for me.

It would be great if these buttons got tooltips or descriptions in the bottom status bar then you could explain the function differences.

Personally I'd be happy if you did any of the following: -Just leave it like this. It is slightly odd that the last breadcrumb button behaves differently, but as you are already inside the final breadcrumb you don't need a button to do that, so it seems ok.
-Like you say make some small change to the last breadcrumb button to indicate the new functionality. You could prepend the final > so it's part of the last button so it's like '>SubPatch4' to indicate it works differently. -Create a new button with a new icon specifically as a 'focus on this op instance' command. It could live between the last breadcrumb and the manage op button. Then you could also put it in the right hand op properties panel (as now with bookmarks it's possible to select an op that isn't in your current patch so might be handy to fly to it)