search

cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

MediaRecorder gets 'Error: canvas not found' if the popout window is open before creating the op #873

Open bejucoo opened 1 month ago

bejucoo commented 1 month ago

Link to simple, reproducible example patch https://cables.gl/p/B9TXjr

Describe the bug If the Popout Canvas is open before adding a MediaRecorder op, it doesn't find the canvas. If I close the popout canvas, record, and reopen the popout, the op works normally.

cablesMediaRecorderError

How To Reproduce

  1. Open Editor
  2. Open the Popout Canvas
  3. Add a MediaRecorder op
  4. Toggle 'Recording' (Error)
  5. Close the Popout Canvas
  6. Toggle 'Recording' (Ok)
  7. Open the Popout Canvas
  8. Toggle 'Recording' (Ok)

Platform

Dev Tools No relevant messages found.

pandrr commented 4 weeks ago

on dev.cables.gl there is now a v2 of the mediaRecorder op, which uses the webGL canvas by default and not canvas by id, which is not working correctly with popout canvas

steam0r commented 3 weeks ago

this is now on cables.gl!