cables-gl / cables_docs

cables documentation docs.cables.gl
https://cables.gl/docs/docs
45 stars 16 forks source link

HSBtoRGB should actually be HSLtoRGB #878

Open esperanc opened 1 month ago

esperanc commented 1 month ago

This is perhaps a petty grievance, but the name and the description of the op is misleading, since it actually converts HSL to RGB, not HSB (a synonym of HSV) to RGB. An actual HSVtoRGB op would also be nice.

pandrr commented 4 weeks ago

on dev.cables.gl there are new HSL to/from RGB ops. they use chroma.js library, which has also HSV functions available, the new ops can easily cloned and converted to those new functions.

https://gka.github.io/chroma.js/

the old HSBtoRGB op will be deprecated in the next release