Closed dyang37 closed 1 year ago
Ok. It looks good to me.
@cabouman A kind reminder on this PR. Once this is merged I'll make similar updates to mace4D interface. After that we may work on the interface change regarding delta_det_row
and delta_det_channel
(issue #107).
This PR contains the updated interface of mace3D function. It looks like a lot of changes, but the majority of the changes are in the interface & docstring part of mace3D function.
Interface available here: mace.pdf
Specifically, here are the changes to the interface:
num_image_rows
,num_image_cols
,num_image_slices
,image_slice_offset
to align the mace interface to the recent interface change regarding ROR recon.ror_radius
.recon
function.Tested with
demo_mace3D.py
anddemo_mace3D_fast.py
, and it worked fine.Once this is done, we will make similar changes to
mace4D
. After that, we may start working on the interface change regardingdelta_det_channel
anddelta_det_row
.